Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ACT_PULP to the new activity actor system #76163

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

SurFlurer
Copy link
Contributor

@SurFlurer SurFlurer commented Sep 3, 2024

Summary

Infrastructure "Migrate ACT_PULP to the new activity actor system."

Purpose of change

#40013

Describe the solution

  1. Migrate ACT_PULP to the new activity actor system.
  2. When it comes to auto pulping adjacent corpses, although multiple activity_actors were pushed into the backlog, the player seemed to only execute the first one. So I chose to store a set of target map squares instead of only one square, and iterate over them, erasing already processed map squares. Computational overhead should be the same as the old system.

Describe alternatives you've considered

Testing

Test suite passes.
I went to the backyard of refugee center, killed everything and 1) watched the guards successfully pulping some corpses 2) manually pulped some 3) auto pulped some.

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 3, 2024
@SurFlurer SurFlurer force-pushed the pulp_actor_2 branch 2 times, most recently from 10c6576 to e376edd Compare September 3, 2024 11:43
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Sep 3, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Sep 3, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 3, 2024
@SurFlurer
Copy link
Contributor Author

Clang-tidy failure seems unrelated?

@Maleclypse
Copy link
Member

I believe you are correct

@Maleclypse Maleclypse merged commit 2a5edfa into CleverRaven:master Sep 5, 2024
21 of 26 checks passed
@SurFlurer SurFlurer deleted the pulp_actor_2 branch September 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants